[bisq-network/bisq] Show close button when creating offer without required account (#2590)
Devin Bileck
notifications at github.com
Tue Mar 26 21:52:10 UTC 2019
Issue: When attempting to create an offer without a trading account for
the selected currency, a prompt is shown asking the user whether to still
create an offer or to create a new account. But this prompt is missing a
cancel/close button in case you don't want to do either action. And
pressing Esc on the keyboard proceeds to create the account.
![image](https://user-images.githubusercontent.com/603793/55036019-98671980-4fd6-11e9-8337-450e0a0e411f.png)
Cause: The close button on the prompt was renamed and being used to
create a new account.
Fix: Use the close button as a close button and add a secondary action
button to create a new account. The popup width was increased to
accommodate the long button text without being truncated.
![image](https://user-images.githubusercontent.com/603793/55036026-9d2bcd80-4fd6-11e9-815f-f75f25f404b0.png)
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/2590
-- Commit Summary --
* Show close button when creating offer without required account
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (5)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/2590.patch
https://github.com/bisq-network/bisq/pull/2590.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2590
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190326/48fab927/attachment.html>
More information about the bisq-github
mailing list