[bisq-network/bisq] Add irregular txType, add check for total balance (#2587)
Manfred Karrer
notifications at github.com
Tue Mar 26 23:55:34 UTC 2019
ManfredKarrer commented on this pull request.
> @@ -179,8 +179,11 @@ private void maybeRevealVotes(int chainHeight) {
.filter(myVote -> myVote.getRevealTxId() == null) // we have not already revealed
.forEach(myVote -> {
boolean isInVoteRevealPhase = periodService.getPhaseForHeight(chainHeight) == DaoPhase.Phase.VOTE_REVEAL;
+ // If we would create the tx in the last block it would be confirmed in the best case in th next
+ // block which would be already the break and would invalidate the vote reveal.
+ boolean isNotLastBlockInPhase = chainHeight != periodService.getLastBlockOfPhase(chainHeight, DaoPhase.Phase.VOTE_REVEAL);
Ok, changed it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2587#discussion_r269360721
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190326/929130aa/attachment.html>
More information about the bisq-github
mailing list