[bisq-network/bisq] Add irregular txType, add check for total balance (#2587)
sqrrm
notifications at github.com
Wed Mar 27 12:18:36 UTC 2019
sqrrm approved this pull request.
utACK
> @@ -142,55 +142,55 @@
"4" : // regtest
BisqEnvironment.getBaseCurrencyNetwork().isDaoBetaNet() ?
"144" : // daoBetaNet; 1 day
- "380", // testnet or dao testnet (server side regtest); 2.6 days
+ "134", // testnet or dao regtest (server side regtest); 2.6 days
```suggestion
"134", // testnet or dao regtest (server side regtest); 0.93 days
```
> ParamType.BLOCK, 2, 2),
PHASE_BLIND_VOTE(BisqEnvironment.getBaseCurrencyNetwork().isMainnet() ?
"451" : // mainnet; 3 days
BisqEnvironment.getBaseCurrencyNetwork().isRegtest() ?
"2" : // regtest
BisqEnvironment.getBaseCurrencyNetwork().isDaoBetaNet() ?
"144" : // daoBetaNet; 1 day
- "300", // testnet or dao testnet (server side regtest); 2 days
+ "134", // testnet or dao regtest (server side regtest); 2 days
```suggestion
"134", // testnet or dao regtest (server side regtest); 0.93 days
```
> ParamType.BLOCK, 2, 2),
PHASE_VOTE_REVEAL(BisqEnvironment.getBaseCurrencyNetwork().isMainnet() ?
"451" : // mainnet; 3 days
BisqEnvironment.getBaseCurrencyNetwork().isRegtest() ?
"2" : // regtest
BisqEnvironment.getBaseCurrencyNetwork().isDaoBetaNet() ?
"144" : // daoBetaNet; 1 day
- "300", // testnet or dao testnet (server side regtest); 2 days
+ "132", // testnet or dao regtest (server side regtest); 2 days
```suggestion
"132", // testnet or dao regtest (server side regtest); 0.93 days
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2587#pullrequestreview-219423239
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190327/412b40d4/attachment.html>
More information about the bisq-github
mailing list