[bisq-network/compensation] [WIP] For March 2019 (#250)

Oscar Guindzberg notifications at github.com
Fri Mar 29 14:15:13 UTC 2019

## Summary

> _Specify the total amount of BSQ you are requesting, and the BSQ address that amount should be paid to:_

 - BSQ requested:
 - BSQ address: B1LiYyuKpAZQHuyzRiFy8uBYNC71S8nEXQJ

## Contributions delivered

> _Provide links to contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19), the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value._

    - bisq’s bitcoinj connection handling changes audit
- Bisq's bitcoinj "addr" message support audit
    - https://github.com/bisq-network/bisq/pull/2591
    - https://github.com/bisq-network/bitcoinj/pull/29 
- bisq’s bitcoinj connection handling changes audit

- Bisq's bitcoinj "addr" message support audit
    - https://github.com/bisq-network/bitcoinj/issues/28 

Mon 25/3
- Update testnet dns seeds https://github.com/bisq-network/bitcoinj/pull/26
- Bisq's bitcoinj "addr" message support audit
- bisq’s bitcoinj fee calculation changes audit
    - Commits to audit
        - https://github.com/oscarguindzberg/bitcoinj/commit/7dd1bfd9c3028266a5f8d1954cbf259ee3907e9b 
    - Suggested fix
        - https://github.com/bisq-network/bitcoinj/pull/27

- bitcoinj tor support audit
    - https://github.com/bisq-network/bitcoinj/issues/25
    - https://github.com/bisq-network/bitcoinj/pull/24 

- bitcoinj tor support audit

- bitcoinj tor support audit
    - Review https://github.com/bisq-network/bitcoinj/commit/011fe40d971631106980c28df3ed8a51e7e875f6  
        - it’s ok, created PR upstream https://github.com/bitcoinj/bitcoinj/pull/1741 
    - Review https://github.com/bisq-network/bitcoinj/commit/834f57a1c17758f46bddb8335f009f010c95ba41  
            - it’s ok, created PR upstream https://github.com/bitcoinj/bitcoinj/pull/1742
    - PR to remove orchid and tor from bitcoinj
        - Removed because it was not well mantained and caused problems
        - https://github.com/bitcoinj/bitcoinj/pull/1314 

- Attend dev call
- Compile bitcoinj with openjdk10 
    - https://github.com/bisq-network/bitcoinj/pull/23
    - https://github.com/bisq-network/bisq/pull/2564 
- Move clear blockstore feature to bitcoinj
    - https://github.com/bisq-network/bitcoinj/pull/22 
    - https://github.com/bisq-network/bisq/pull/2563 

mon 18/3
- Compile bitcoinj with openjdk10 
- Investigate: Error at BitcoinJ deserializing message https://github.com/bisq-network/bisq/issues/2557 

- TxBroadcaster code review 
    - TxBroadcaster review
        - Code review https://github.com/oscarguindzberg/bisq/commit/82ef7921b944f9ede3817d0cca031e16ff957416 
        - Write TxBroadcaster improvements PR https://github.com/bisq-network/bisq/pull/2536
        - Rebroadcasting research
            - Discuss on bitcoinj mailing list https://groups.google.com/forum/#!topic/bitcoinj/lkK9N3NhoPY 
            - Read thread about “reject” msg removal in bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html 
- Signet network research
    - It is a “stable testnet” with proof of authority.
    - Read email thread on bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016734.html
    - Start bitcoinj signet implementation https://github.com/oscarguindzberg/bitcoinj/tree/signet 

    - TxBroadcaster code review 

- Code review of https://github.com/bisq-network/bisq/pull/2524
    - Suggest inform shutdown on button label - https://github.com/bisq-network/bisq/pull/2530 
- Complete “Restore from seed using blockstore.clear() fix” upstream PR https://github.com/bitcoinj/bitcoinj/pull/1702
- Try to reproduce “On regtest, after funds withdrawal, the ui balance is not decreased” -> could not reproduce it anymore.
- TxBroadcaster code review 

    - Code review of https://github.com/bisq-network/bisq/pull/2517 
    - test restore from seed with https://github.com/oscarguindzberg/bisq/commit/d307fa8179e26c15250ded8cc8bde0c17d2d00f4 

- Retest bitcoinj upstream bug https://github.com/bitcoinj/bitcoinj/issues/1704 because I was told it was solved. Report what is working and what is not. I had to update to java 11 (which was a complicated task) because the wallet template bitcoinj subproject now requires that. It's important for us that have a benchmark wallet to know how restore from seed should work on bitcoinj.
- "Restore from seed" does not work on windows: re-test because bugs were reported. Could not reproduce any bugs.

## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional,** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

- Investigate moving to bitcoinj upstream master
  - https://groups.google.com/forum/#!topic/bitcoinj/M05pt8Hwnw0
  - https://groups.google.com/forum/#!topic/bitcoinj/qjxgcpKak3s
  - Participate in https://github.com/bisq-network/bisq/issues/1139 
  - https://groups.google.com/forum/#!topic/bitcoinj/kE6hO3Cj8-Q 
  - Review bitcoinj master source code
  - Review https://github.com/bitcoinj/bitcoinj/pull/1563 (see my comments)
  - Send email asking for 0.15 release notes - https://groups.google.com/forum/#!topic/bitcoinj/kE6hO3Cj8-Q
  - Investigate segwit bip144 support in bitcoinj https://groups.google.com/forum/#!topic/bitcoinj/qjxgcpKak3s

## Roles performed

> _Provide links to your [monthly report](https://github.com/bisq-network/proposals/issues/13) on any roles you are responsible for._

- bitcoinj branch mantainer

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190329/ecd811c1/attachment-0001.html>

More information about the bisq-github mailing list