[bisq-network/bisq] Add irregular txType, add check for total balance, prevent proposal withhold attack (#2587)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



>  
         if (sumBsq != sumUtxo) {
-            throw new RuntimeException("There is a mismatch between the UTXO set and the DAO state. Please contact the Bisq devlopers.");
+            utxoMismatches.add(new UtxoMismatch(block.getHeight(), sumUtxo, sumBsq));

Yes. Need to improve that. Popups are handled in the UI to not repeat but still we don't want to add it at each block again. But anyway should not happen at all, is just to double check if we missed something. So I consider it more as a developer tool...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2587#discussion_r270639490
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190330/5d42e633/attachment.html>