[bisq-network/bisq] Trade Info Popup (#3329)

Florian Reimair notifications at github.com
Mon Nov 4 11:55:13 UTC 2019


freimair requested changes on this pull request.

Ack, but please use the `@Setter` instead of create the setter method by hand

> @@ -70,6 +73,11 @@
     @Nullable
     protected final Map<String, String> excludeFromJsonDataMap;
 
+    @JsonExclude
+    @Getter(AccessLevel.NONE)
+    @Setter(AccessLevel.NONE)    

```suggestion
    @Setter
```

> +    
+    public void setPaymentDetails(String paymentDetails) {
+    	this.paymentDetails = paymentDetails;
+    }

remove

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3329#pullrequestreview-311020571
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191104/cc91e23c/attachment.html>


More information about the bisq-github mailing list