[bisq-network/bisq] Trade Info Popup (#3329)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - please see my comment

> +    @JsonExclude
+    @Getter(AccessLevel.NONE)
+    @Setter    
+	protected String paymentDetails;
+

Please don't use the protocol buffers files to store this kind of information. It is very risky and it needs additional backwards comp. testing to make sure everything is 100% working.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3329#pullrequestreview-311589185
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191105/9bd9f221/attachment.html>