[bisq-network/bisq] Reputation BSQ added to BSQ Wallet screen (#3366)
sqrrm
notifications at github.com
Tue Nov 5 15:50:35 UTC 2019
sqrrm requested changes on this pull request.
NACK
> @@ -62,10 +72,11 @@
@Inject
private BsqBalanceUtil(BsqWalletService bsqWalletService,
DaoStateService daoStateService,
- BsqFormatter bsqFormatter) {
+ BsqFormatter bsqFormatter, MyBlindVoteListService myBlindVoteListService) {
Please follow local formatting, either line break at each argument or fit as many arguments as possible before line break.
> @@ -18,11 +18,14 @@
package bisq.desktop.main.dao.wallet;
import bisq.desktop.components.TitledGroupBg;
+import bisq.desktop.main.dao.wallet.tx.BsqTxListItem;
Remove unused imports
> @@ -42,7 +42,7 @@
@Slf4j
@EqualsAndHashCode(callSuper = true)
@Data
-class BsqTxListItem extends TxConfidenceListItem {
+public class BsqTxListItem extends TxConfidenceListItem {
Don't change access for no reason
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3366#pullrequestreview-311795329
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191105/fccba540/attachment.html>
More information about the bisq-github
mailing list