[bisq-network/bisq] (1/4) [TESTS] Add tests for P2PDataStorage in order to safely refactor (#3554)

[Julian Knutsen]

julianknutsen commented on this pull request.



> @@ -221,6 +221,7 @@ configure(project(':p2p')) {
         testCompileOnly "org.projectlombok:lombok:$lombokVersion"
         testAnnotationProcessor "org.projectlombok:lombok:$lombokVersion"
         testCompile("org.mockito:mockito-core:$mockitoVersion")
+        testCompile project(':core')

Agreed. This was done early on when I didn't understand the protobuf hashing interaction. The new stub class makes the tests much nicer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3554#discussion_r342658449
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191105/86dcb018/attachment.html>