[bisq-network/bisq] Reputation BSQ added to BSQ Wallet screen (#3366)

[niyid]

@sqrrm
All fixed. Thanks.

On Tue, Nov 5, 2019 at 4:50 PM sqrrm <notifications at github.com> wrote:

> *@sqrrm* requested changes on this pull request.
>
> NACK
> ------------------------------
>
> In desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
> <https://github.com/bisq-network/bisq/pull/3366#discussion_r342610718>:
>
> > @@ -62,10 +72,11 @@
>      @Inject
>      private BsqBalanceUtil(BsqWalletService bsqWalletService,
>                             DaoStateService daoStateService,
> -                           BsqFormatter bsqFormatter) {
> +                           BsqFormatter bsqFormatter, MyBlindVoteListService myBlindVoteListService) {
>
> Please follow local formatting, either line break at each argument or fit
> as many arguments as possible before line break.
> ------------------------------
>
> In desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java
> <https://github.com/bisq-network/bisq/pull/3366#discussion_r342610906>:
>
> > @@ -18,11 +18,14 @@
>  package bisq.desktop.main.dao.wallet;
>
>  import bisq.desktop.components.TitledGroupBg;
> +import bisq.desktop.main.dao.wallet.tx.BsqTxListItem;
>
> Remove unused imports
> ------------------------------
>
> In
> desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxListItem.java
> <https://github.com/bisq-network/bisq/pull/3366#discussion_r342611121>:
>
> > @@ -42,7 +42,7 @@
>  @Slf4j
>  @EqualsAndHashCode(callSuper = true)
>  @Data
> -class BsqTxListItem extends TxConfidenceListItem {
> +public class BsqTxListItem extends TxConfidenceListItem {
>
> Don't change access for no reason
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/bisq/pull/3366?email_source=notifications&email_token=AE2MWR5FH4VPFG7KB2OI4GTQSGI4ZA5CNFSM4I5476X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKKZ5AI#pullrequestreview-311795329>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE2MWR4KQ4GPOSDJBZJ7BFDQSGI4ZANCNFSM4I5476XQ>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3366#issuecomment-549924962
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191105/29b6fd03/attachment.html>