[bisq-network/bisq] Limit max. nr. of PersistableNetworkPayload and ProtectedStorageEntries (#3562)

Julian Knutsen notifications at github.com
Wed Nov 6 17:10:16 UTC 2019


julianknutsen commented on this pull request.



>                  .map(Map.Entry::getValue)
                 .collect(Collectors.toSet());
+        if (maxSize.get() <= 0) {
+            log.warn("The peer request caused too much ProtectedStorageEntry entries to get delivered. We limited the entries for the response to {} entries", MAX_ENTRIES);

Is the UpdateDataRequest the only way to retrieve items > 10,000? What if the total set is larger than what the Initial & Update can handle? Is there a periodic on as well to sync over time?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3562#pullrequestreview-312600818
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191106/14672875/attachment-0001.html>


More information about the bisq-github mailing list