[bisq-network/bisq] Re-introduce account age to chargeback risk payment methods (#3580)

[sqrrm]

sqrrm requested changes on this pull request.

Please have look at comments, especially on the usage of account age category

>  
         // outer circle
         Color ringColor;
         if (isFiatCurrency) {
 
-            switch (accountAgeWitnessService.getPeersAccountAgeCategory(peersAccount.first)) {
+            switch (accountAgeWitnessService.getPeersAccountAgeCategory(accountAge)) {

I think this should switch on `accountAge` for non signed accounts and switch on `signAge` for signed accounts.

Possibly it should switch on `signAge` for all accounts of risky payment methods. Otherwise it will show that an older account that isn't signed is safe, even though it's a risky method.

> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.common.util;
+
+import java.util.Objects;
+
+public class Tuple5<A, B, C, D, E> {
+    final public A first;
+    final public B second;
+    final public C third;
+    final public D forth;

fourth

> +    }
+
+    @SuppressWarnings("SimplifiableIfStatement")
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (!(o instanceof Tuple5)) return false;
+
+        Tuple5<?, ?, ?, ?, ?> tuple5 = (Tuple5<?, ?, ?, ?, ?>) o;
+
+        if (!Objects.equals(first, tuple5.first)) return false;
+        if (!Objects.equals(second, tuple5.second)) return false;
+        if (!Objects.equals(third, tuple5.third)) return false;
+        if (!Objects.equals(forth, tuple5.forth)) return false;
+        return Objects.equals(fifth, tuple5.fifth);
+

Extra blank line

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3580#pullrequestreview-314469732
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191108/b934c189/attachment.html>