[bisq-network/bisq] Remove mutating functions of ProtectedStorageEntry (#3582)

[Julian Knutsen]

New commit is 9d64022

This is good clean up anyway, but it will make more sense with the next 2 pull requests that start changing the ProtectedStorageEntry and ProtectedMailboxStorageEntry APIs.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3582

-- Commit Summary --

  * [TESTS] Add tests for P2PDataStorage in order to safely refactor
  * [BUGFIX] Call correct remove function in addMailboxData failure path.
  * [REFACTOR] P2PDataStorage::addPersistableNetworkPayload()
  * [REFACTOR] P2PDataStorage::addProtectedStorageEntry()
  * [REFACTOR] P2PDataStorage::refreshTTL()
  * [REFACTOR] P2PDataStorage::remove()
  * [REFACTOR] P2PDataStorage::removeMailboxData()
  * Update behavior of P2PDataStorage::addProtectedStorageEntry() on duplicates
  * Update behavior of P2PDataStorage::refreshTTL() on duplicates
  * Update behavior of P2PDataStorage::remove() & removeMailboxData() on duplicate sequence #s
  * [PR COMMENTS] Don't use the real Alert class
  * Merge branch 'add-tests' into fix-remove-bug
  * [PR COMMENTS] Don't call removeMailboxData in addMailboxData failure path
  * Merge branch 'fix-remove-bug' into refactor-add-remove-refresh
  * [PR COMMENTS] Clean up logging messages
  * Merge branch 'refactor-add-remove-refresh' into update-duplicate-behavior
  * [TESTS] Reduce concurrent failure tests to 2 concurrent operations instead of 3
  * Merge branch 'master' into add-tests
  * [PR COMMENTS] Use Client API in comments
  * Merge branch 'add-tests' into fix-remove-bug
  * [PR COMMENTS] Remove concurrent tests
  * Merge branch 'fix-remove-bug' into refactor-add-remove-refresh
  * [PR COMMENTS] Use "Client API" in transient comments
  * Merge branch 'refactor-add-remove-refresh' into update-duplicate-behavior
  * Use dependency injected Clock in P2PDataStore
  * [REFACTOR] Clean up ProtectedStorageEntry ctor
  * Add Clock parameter to ProtectedStorageEntry
  * Use Clock instead of System in ProtectedStorageEntry
  * [TESTS] Use ClockFake in tests to control time
  * [TESTS] Test onBootstrapComplete()
  * [TESTS] Lower entries required for purge in tests
  * [PR COMMENTS] Don't store Clock in ProtectedStorageEntry
  * Merge branch 'master' into add-tests
  * Merge branch 'add-tests' into fix-remove-bug
  * Merge branch 'fix-remove-bug' into refactor-add-remove-refresh
  * Merge branch 'refactor-add-remove-refresh' into update-duplicate-behavior
  * Merge branch 'update-duplicate-behavior' into manual-clock-in-tests
  * [REFACTOR] Remove duplicated code in refreshTTL

-- File Changes --

    M common/src/main/java/bisq/common/proto/network/NetworkProtoResolver.java (4)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (6)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (5)
    M monitor/src/main/java/bisq/monitor/metric/P2PNetworkLoad.java (6)
    M monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshotBase.java (4)
    M p2p/src/main/java/bisq/network/p2p/P2PService.java (10)
    M p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java (402)
    M p2p/src/main/java/bisq/network/p2p/storage/payload/ProtectedMailboxStorageEntry.java (66)
    M p2p/src/main/java/bisq/network/p2p/storage/payload/ProtectedStorageEntry.java (77)
    M p2p/src/test/java/bisq/network/p2p/TestUtils.java (5)
    M p2p/src/test/java/bisq/network/p2p/storage/P2PDataStorageTest.java (1673)
    M p2p/src/test/java/bisq/network/p2p/storage/ProtectedDataStorageTest.java (4)
    M p2p/src/test/java/bisq/network/p2p/storage/messages/AddDataMessageTest.java (4)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/AppendOnlyDataStoreServiceFake.java (42)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/ClockFake.java (49)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/DateTolerantPayloadStub.java (50)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/PersistableNetworkPayloadStub.java (43)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/ProtectedDataStoreServiceFake.java (45)
    A p2p/src/test/java/bisq/network/p2p/storage/mocks/ProtectedStoragePayloadStub.java (64)
    A p2p/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3582.patch
https://github.com/bisq-network/bisq/pull/3582.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3582
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191108/63a49bc4/attachment-0001.html>