[bisq-network/bisq] Show BSQ trade fee in % per day (#3357)

[Florian Reimair]

freimair requested changes on this pull request.

looks good. except for the formatting issues. Please resolve them and then we can get this PR merged.

> @@ -327,7 +329,8 @@ private CurrencyListItem specialShowAllItem() {
     // Chart
     ///////////////////////////////////////////////////////////////////////////////////////////
 
-    private void createCharts() {
+    @SuppressWarnings("unchecked")
+	private void createCharts() {

formatting seems off

```suggestion
    private void createCharts() {
```

> @@ -430,11 +437,12 @@ public Number fromString(String string) {
         });
         //noinspection unchecked
         volumeChart.setId("volume-chart");
-        volumeChart.setData(FXCollections.observableArrayList(volumeSeries));
+        //TODO bisqBurnSeries should only be added when model.getCurrencyCode() == "BSQ" ???

imo no, every time, since BSQ can be used to fund all transaction fees

@chimp1984 ?



> +        
+		for (Tx item : burntBsqSet) {
+			accumulatedBisqBurn += item.getBurntBsq();
+		}
+                
+        //TODO compute bisqBurnVolumeRatio
+		double accumulatedBisqBurnAsDouble = (double) accumulatedBisqBurn;
+		bisqBurnVolumeRatio = accumulatedMetricAsDouble != 0 ? accumulatedBisqBurnAsDouble * 100.0 / accumulatedMetricAsDouble : 0l;//Percentage calculation
+				

formatting seems off. We use space-only indentation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3357#pullrequestreview-314551929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191109/9a1ed82b/attachment.html>