[bisq-network/bisq] Added check for empty validation (#3573)

[Florian Reimair]

freimair requested changes on this pull request.



>          }
+        else{   // only account number not empty validation

please format the code to match the other formatting. (If you are using IntelliJ IDEA: [Code][Reformat])

> @@ -240,28 +240,28 @@ public void addFormForAddAccount() {
         bankNameInputTextField = addInputTextField(gridPane, ++gridRow, Res.get("payment.bank.name"));
 
         bankNameInputTextField.textProperty().addListener((ov, oldValue, newValue) -> {
-            bankAccountPayload.setBankName(newValue);
+            bankAccountPayload.setBankName(newValue.trim());

I wonder if we should include this functionality to the `BankAccountPayload` class itself. @ripcurlx what is your opinion?

> @@ -75,7 +75,7 @@ public void addFormForAddAccount() {
 
     @Override
     protected void autoFillNameTextField() {
-        setAccountNameWithString(accountIdInputTextField.getText());
+        setAccountNameWithString(accountIdInputTextField.getText().trim());

same as above. Should we add the "trim" to the base class `PaymentMethodForm`? or is there a single payment method that needs leading/trailing whitespaces? @ripcurlx what is your opinion?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3573#pullrequestreview-314147401
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191109/af7fabfd/attachment.html>