[bisq-network/bisq] (1/8) [TESTS] Add tests for P2PDataStorage in order to safely refactor (#3554)

Julian Knutsen notifications at github.com
Sat Nov 9 15:38:05 UTC 2019


As far as splitting up the tests, you are going to run into a situation where helper files are needed for the common test code or the parent unti test fixture and navigating the tests to understand what is going on is even harder to read (I went down this path initially).

The reality is that this test code is complicated and has a ton of embedded/shared code because the module was extremely hard to test in the current state. The goal of this first patch was to get everything fully tested in the "best" way possible, so the future work could refactor it into something much easier to work with. The version of the tests after (#3584) are much cleaner after the unit tests of ProtectedStorageEntry and ProtectedMailboxStorageEntry could be unit tested.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3554#issuecomment-552111040
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191109/0c895631/attachment.html>


More information about the bisq-github mailing list