[bisq-network/bisq] Clean up trade statistics from duplicate entries (#3476)

Julian Knutsen notifications at github.com
Sat Nov 9 21:10:17 UTC 2019


julianknutsen commented on this pull request.



> @@ -240,7 +242,12 @@ public void onMessage(NetworkEnvelope networkEnvelope, Connection connection) {
                                     // Processing 82645 items took now 61 ms compared to earlier version where it took ages (> 2min).
                                     // Usually we only get about a few hundred or max. a few 1000 items. 82645 is all
                                     // trade stats stats and all account age witness data.
-                                    dataStorage.addPersistableNetworkPayloadFromInitialRequest(e);
+
+                                    // We only apply it once from first response
+                                    if (!initialRequestApplied) {

Why do we only handle the first requests for the PersistableNetworkPayload objects, but all of them for the ProtectedStoragePayload objects? Do we expect more inconsistencies between the ProtectedStorageEntrys so we use all of them? Or, were the PersistableNetworkPayload handlers not dealing with duplicates well?

I haven't been able to follow the entire TradeStatstics issue, but I am just trying to understand more about what is expected/unexpected in this startup path.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3476#pullrequestreview-314577945
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191109/e02fae8e/attachment.html>


More information about the bisq-github mailing list