[bisq-network/bisq] Fix small p2p network issues (#3154)

Julian Knutsen notifications at github.com
Sun Nov 10 04:07:21 UTC 2019


julianknutsen commented on this pull request.



> + *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.network.p2p.storage.messages;
+
+/**
+ * Marker interface for messages which must not be added again after a remove message has been received (e.g. MailboxMessages).
+ */
+public interface AddOncePayload {

Is there an issue number that this change fixes? After reviewing and refactoring this code I'm having trouble understanding the bug that would have needed this fix. I'd like to try and reproduce it in my tests, if possible. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3154#pullrequestreview-314589180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191109/bc75f481/attachment-0001.html>


More information about the bisq-github mailing list