[bisq-network/bisq] (1/8) [TESTS] Add tests for P2PDataStorage in order to safely refactor (#3554)

[Julian Knutsen]

All of these incremental ones can be individually reviewed and merge. They are all just branches of the previous PR in the stack that I have been merging down to keep them consistent with master and each other.

After doing this style for a week, it is really busy and hard to read after 1-2 resyncs from master and 1-2 change requests. I want to make this as easy as possible on you guys and understand the best way forward for future patches.

 I can either:

1. rebuild individual incremental PRs using rebase to clean up all the merges
2. leave it as-is

I like the idea of having small incremental PRs so that if there is some design discussion and rework in 7/8, the previous patches that include bugfixes and tests can still make it in and raise the quality. But, I think choosing something that works best for you guys as the reviewers to make it easy to audit and verify changes is the best path forward.

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3554#issuecomment-552209596
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191110/8f980b23/attachment.html>