[bisq-network/bisq] (2/8) [BUGFIX] Call correct remove function in addMailboxData failure path. (#3556)

Julian Knutsen notifications at github.com
Mon Nov 11 00:55:56 UTC 2019


Ok. I've rebased this branch with master now to see how it looks. In my opinion, this is much easier to review than the wall of merges before and it will have a clean history once it is goes through the merge-commit path. The downside is the prior files are gone that the code review comments referenced, but the comments are still visible so the reviewers can verify the changes were actually implemented.

Let me know what you think and if this is a good path moving forward.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3556#issuecomment-552254857
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191110/ab1fa358/attachment-0001.html>


More information about the bisq-github mailing list