[bisq-network/bisq] PaymentAccount object removal from ObservableSet issue (#3572)

beingindot notifications at github.com
Mon Nov 11 14:36:39 UTC 2019


beingindot commented on this pull request.



> +    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        PaymentAccount that = (PaymentAccount) o;
+        return creationDate == that.creationDate &&
+                id.equals(that.id);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(id, creationDate);
+    }
+

`accountName` field is for test only I have added. In reality, we couldn't delete the object immediately after creation.(Not sure which field causes this)
Hence i feel it should be applied to entire class. pls let me know if otherwise.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3572#discussion_r344739702
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191111/fbb81071/attachment.html>


More information about the bisq-github mailing list