[bisq-network/bisq-markets] Re-implement Markets API service with pre-caching proxy + risq backend (#20)

[dan-da]

>From the OP: 

> Since trades on Bisq do not happen very frequently, this cache time seems reasonable trade-off for the performance gains.

I will just note here that the way the filecache works in the original code, data is cached indefinitely until the underlying bisq json file is written to, and then the json file is atomically read and cached.  This means that the service never serves stale data, even with caching enabled. (At least to the extent that the backend node is in sync with the p2p network).   It seems the new system does not preserve that property.

> Of course using a fully self-hosted solution is preferable to using Google Appengine, since Google would have a log of all IP addresses that access the proxy hosted on their appengine platform, and Bisq should always protect the privacy of Bisq users as much as possible.

seriously?  To me, this is a non-starter for using Google Appengine.   Have you looked at using a reverse proxy cache like [varnish](https://varnish-cache.org/) locally instead? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-markets/pull/20#issuecomment-552515974
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191111/49ad3c87/attachment.html>