[bisq-network/bisq] Move Payment account creation and removal from UI to core (#3586)
Bernard Labno
notifications at github.com
Tue Nov 12 11:18:46 UTC 2019
blabno commented on this pull request.
> - if (singleTradeCurrency instanceof FiatCurrency)
- preferences.addFiatCurrency((FiatCurrency) singleTradeCurrency);
- else
- preferences.addCryptoCurrency((CryptoCurrency) singleTradeCurrency);
- } else if (tradeCurrencies != null && !tradeCurrencies.isEmpty()) {
- tradeCurrencies.stream().forEach(tradeCurrency -> {
- if (tradeCurrency instanceof FiatCurrency)
- preferences.addFiatCurrency((FiatCurrency) tradeCurrency);
- else
- preferences.addCryptoCurrency((CryptoCurrency) tradeCurrency);
- });
- }
-
- if (!(paymentAccount instanceof AssetAccount))
- accountAgeWitnessService.publishMyAccountAgeWitness(paymentAccount.getPaymentAccountPayload());
+ paymentAccountManager.addPaymentAccount(paymentAccount);
}
public boolean onDeleteAccount(PaymentAccount paymentAccount) {
I think it's better to propagate the exception and handle it on the view layer, but wanted to do as little changes as possible in order not to overwhelm maintainers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3586#discussion_r345148993
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191112/ad561143/attachment-0001.html>
More information about the bisq-github
mailing list