[bisq-network/bisq] Increase "Proposals of current cycle" table size to fit the window (#3318)

niyid notifications at github.com
Tue Nov 12 12:40:01 UTC 2019


Thanks for the feedback. I will adopt your suggestion.

Regards.

On Tue, Nov 12, 2019, 13:37 Christoph Atteneder <notifications at github.com>
wrote:

> *@ripcurlx* requested changes on this pull request.
>
> @niyid <https://github.com/niyid> Your fixes improves on first sight the
> height of the open proposals, but as soon as the blind voting is on it
> hides an important part behind off screen.
> [image: Bildschirmfoto 2019-11-12 um 13 19 58]
> <https://user-images.githubusercontent.com/170962/68671278-3fd99200-054f-11ea-95e2-11eebd62cd1c.png>
> [image: Bildschirmfoto 2019-11-12 um 13 20 03]
> <https://user-images.githubusercontent.com/170962/68671288-47993680-054f-11ea-8358-70da628c0060.png>
>
> Master in Blind vote phase:
> [image: Bildschirmfoto 2019-11-12 um 13 31 22]
> <https://user-images.githubusercontent.com/170962/68671911-c347b300-0550-11ea-9083-5f86a2f65f30.png>
>
> The right way to fix this would be to adapt the double
> initialProposalTableViewHeight = 180; and tableView.setPrefHeight(100);
> based on the proposal phase, as atm it resizes only correctly in the Blind
> vote phase.
>
>> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/bisq/pull/3318?email_source=notifications&email_token=AE2MWRYCS5CVML772MDUQ4TQTKPQNA5CNFSM4IZ2FHS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHCX4Y#pullrequestreview-315501555>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE2MWRYRHBTGN6RNG5KAYCLQTKPQNANCNFSM4IZ2FHSQ>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3318#issuecomment-552876465
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191112/79dbbeab/attachment.html>


More information about the bisq-github mailing list