[bisq-network/bisq] Trade Info Popup (#3329)

Christoph Atteneder notifications at github.com
Tue Nov 12 13:50:31 UTC 2019


ripcurlx requested changes on this pull request.

NACK - I stopped reviewing (please see my comments). Actually everything is wrong in this PR. Please have a look what you are doing in your code before pushing changes or submitting PRs.

> @@ -60,8 +61,9 @@ protected void run() {
                 failed("Payment method is banned.\n" +
                         "Payment method=" + trade.getOffer().getPaymentMethod().getId());
             } else if (filterManager.isPeersPaymentAccountDataAreBanned(paymentAccountPayload, appliedPaymentAccountFilter)) {
+            	String paymentDetails = Res.getWithCol("payment.altcoin.sender.address", trade.getOffer().getCurrencyCode());

This absolutely wrong it would change the paymentDetails displayed e.g. for MoneyBeam you would replace `Res.get(paymentMethodId) + " - " + Res.getWithCol("payment.account") + " " + accountId;` with `Res.getWithCol("payment.altcoin.sender.address", trade.getOffer().getCurrencyCode());`

> @@ -175,9 +179,9 @@ private void addContent() {
                 nrOfDisputesAsBuyer + " / " + nrOfDisputesAsSeller);
 
         addConfirmationLabelTextFieldWithCopyIcon(gridPane, ++rowIndex, Res.get("shared.paymentDetails", Res.get("shared.buyer")),
-                contract.getBuyerPaymentAccountPayload().getPaymentDetails()).second.setMouseTransparent(false);
+        		buyerPaymentDetails).second.setMouseTransparent(false);

You are removing  the real payment details with e.g. `Sender's BTC address`

>          addConfirmationLabelTextFieldWithCopyIcon(gridPane, ++rowIndex, Res.get("shared.paymentDetails", Res.get("shared.seller")),
-                sellerPaymentAccountPayload.getPaymentDetails()).second.setMouseTransparent(false);
+                sellerPaymentDetails).second.setMouseTransparent(false);

same here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3329#pullrequestreview-315536773
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191112/1679fec1/attachment-0001.html>


More information about the bisq-github mailing list