[bisq-network/bisq] Account validation (#3575)
Christoph Atteneder
notifications at github.com
Wed Nov 13 16:45:52 UTC 2019
ripcurlx requested changes on this pull request.
NACK - Please see my comments
> @@ -87,7 +87,7 @@ public void addFormForAddAccount() {
@Override
protected void autoFillNameTextField() {
- setAccountNameWithString(mobileNrInputTextField.getText());
+ setAccountNameWithString(mobileNrInputTextField.getText().trim());
That is not necessary anymore as your other PR got merged already.
> @@ -75,7 +75,7 @@ public void addFormForAddAccount() {
@Override
protected void autoFillNameTextField() {
- setAccountNameWithString(accountIdInputTextField.getText());
+ setAccountNameWithString(accountIdInputTextField.getText().trim());
That is not necessary anymore as your other PR got merged already.
> @@ -85,7 +85,7 @@ public void addFormForAddAccount() {
@Override
protected void autoFillNameTextField() {
- setAccountNameWithString(accountIdInputTextField.getText());
+ setAccountNameWithString(accountIdInputTextField.getText().trim());
That is not necessary anymore as your other PR got merged already.
> @@ -102,7 +102,7 @@ private void addCurrenciesGrid(boolean isEditable) {
@Override
protected void autoFillNameTextField() {
- setAccountNameWithString(accountIdInputTextField.getText());
+ setAccountNameWithString(accountIdInputTextField.getText().trim());
That is not necessary anymore as your other PR got merged already.
> @@ -92,7 +92,7 @@ private void addCurrenciesGrid(boolean isEditable) {
@Override
protected void autoFillNameTextField() {
- setAccountNameWithString(accountIdInputTextField.getText());
+ setAccountNameWithString(accountIdInputTextField.getText().trim());
That is not necessary anymore as your other PR got merged already.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3575#pullrequestreview-316389836
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191113/03868985/attachment.html>
More information about the bisq-github
mailing list