[bisq-network/bisq] Refactorings for api support (#3611)

[chimp1984]

For API access we need to move code for creating an offer to the core module.
https://github.com/chimp1984/bisq/tree/grpc is based on that code. This PR does not add anythign API related just prepares the required refactoring. 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3611

-- Commit Summary --

  * Remove trailing spaces
  * Add toProtoTradeStatistics2 method
  * Add CreateOfferService class
  * Remove commented out code
  * User weaker access, add final
  * Add getRandomOfferId method
  * Add getSellerSecurityDeposit method
  * Add getEstimatedFeeAndTxSize method
  * Use methods from createOfferService
  * Use txFeeFromFeeService from createOfferService
  * Use getPriceAsLong from createOfferService
  * Use marketPriceMarginParam from createOfferService
  * Pass useMarketBasedPriceValue to getPriceAsLong
  * Use getMaxTradeLimit from createOfferService
  * Use createAndGetOffer from createOfferService
  * Remove unused fields
  * Add createOfferService, remove unused params
  * Use weaker access
  * Add null checks
  * Add log of params, Cleanup
  * Remove unused fields
  * Use weaker access
  * Remove trivial methods
  * Remove trivial methods, rename methods
  * Sort params for offer as they are used
  * Use getReservedFundsForOffer from createOfferService
  * Add MakerFeeProvider
  * Adjust to new super class params
  * Remove sellerSecurityDeposit field, refactor placeOffer
  * Adjust tests to new params

-- File Changes --

    A core/src/main/java/bisq/core/offer/CreateOfferService.java (350)
    A core/src/main/java/bisq/core/offer/MakerFeeProvider.java (29)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (14)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (13)
    M core/src/main/resources/btc_regtest.seednodes (4)
    M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (194)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java (20)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (19)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModelTest.java (13)
    M desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java (15)
    M desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java (11)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3611.patch
https://github.com/bisq-network/bisq/pull/3611.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3611
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191114/cbc15468/attachment.html>