[bisq-network/bisq] PaymentAccount object removal from ObservableSet issue (#3572)

[Julian Knutsen]

Yes, the screenshots show the tradeCurrencies object was different inside the debugger at insert time and remove time. This is confirmed with the patch that "fixes" it by moving the insert until after the tradeCurrencies are set.

A quick run through the UI shows that none of the other fields are modifiable after creation time, but I don't have enough background to know other operations that modify that state and if it will have the same issue. For example, can the list of supported currencies change after creation time which would cause the hash to change again?

It seems like using the fields that are guaranteed to be unique and stable is the way to go, but I'll leave that to the devs with more knowledge of that area.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3572#issuecomment-554221889
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191114/0b00b7e0/attachment-0001.html>