[bisq-network/bisq] Update contributing.md (#3613)

Christoph Atteneder notifications at github.com
Fri Nov 15 14:24:44 UTC 2019


> Why is that a question for me? I already sign all my commits. I didn't raise the issue for myself, it's necessary to have a bigger picture when making workflow changes that effect everybody.

I asked you this question just to point out that being able to sign your commits based on the very good documentation by GitHub is not that complicated. Also if you just want to fix typos with the benefit I mentioned above.
Do you have the feeling this change of workflow needs discussion by the broader developer community or did you mainly want to point out PRs in the Bisq repo are merged too quickly in general?

That PRs are merged in different speeds has something to do by whom they are submitted. Is it by a long time contributor and it gets the required ACKs then it can be merged quite quickly as well. Also it depends if it is a simple UI change or something more critical. I don't have the feeling so far that on PRs that were around for longer more contributors are starting to review them, did you? We do have more the problem atm that PRs are open for too long as the load on maintainers to review is quite high.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3613#issuecomment-554378124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/3c8be508/attachment.html>


More information about the bisq-github mailing list