[bisq-network/bisq] (5/8) Test P2PDataStore expiration code and make testing time sensitive code easier. (#3568)

[Florian Reimair]

freimair requested changes on this pull request.

utAck. However, see inline comment...

> @@ -121,6 +124,8 @@
     private final Set<ProtectedDataStoreListener> protectedDataStoreListeners = new CopyOnWriteArraySet<>();
     private final Clock clock;
 
+    protected int maxSequenceNumberMapSizeBeforePurge;

can we have a 
```suggestion
    protected static final int MAX_SEQUENCE_NUMBER_MAP_SIZE_BEFORE_PURGE;
```
or at least 
```suggestion
    protected final int maxSequenceNumberMapSizeBeforePurge;
```
?

or as I am sure you thought about that, why did you decide against that in the first place?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3568#pullrequestreview-317691963
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/f874ac8e/attachment.html>