[bisq-network/bisq] Refactor of FilterWindow (#3616)
Ćukasz Usarz
notifications at github.com
Fri Nov 15 16:55:08 UTC 2019
Pull request includes 4 commits, it would be easier to review them one by one. Short description of them
- [in first one](https://github.com/bisq-network/bisq/commit/96046fa110028b5096e827a2238393b0d7fd837a) I moved repated code like:
if (values != null)
field.setText(values.stream().collect(Collectors.joining(", ")));
into `setupFieldFromList` method
- [second](https://github.com/bisq-network/bisq/commit/415648e257f4718eac931741deea46b8f3130cf2) and [third](https://github.com/bisq-network/bisq/commit/0c2639a87b2930cc0eff29d31cf31bf00987becb) moves some code into private methods to make `addContent` method smaller and simpler
- [last one](https://github.com/bisq-network/bisq/commit/a6ee5d5c457601f3d1cecb31272461d0dc7854bc) is just small reformatting
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3616
-- Commit Summary --
* Extract setupFieldFromList method in FilterWindow
* Extract readAsPaymentAccountFiltersList method in FilterWindow
* Extract setupFieldFromPaymentAccountFiltersList method in FilterWindow
* Reformat sendButton handler in FilterWindow
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (110)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3616.patch
https://github.com/bisq-network/bisq/pull/3616.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3616
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/1c990fe0/attachment.html>
More information about the bisq-github
mailing list