[bisq-network/bisq] Remove redundant interfaces from FilterWindow and SendAlertMessageWindow (#3617)

Ɓukasz Usarz notifications at github.com
Fri Nov 15 17:03:26 UTC 2019


Interfaces like [these](https://github.com/bisq-network/bisq/blob/d55114e019fda469266dab50f63916289b2e71cb/desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java#L60-L69) are redundant, and unnecessarily increase the complexity of the code. In this pull request I remove them and use appropriate methods like `filterManager.addFilterMessageIfKeyIsValid` directly. It's separated into 2 commits:
- [first one](https://github.com/bisq-network/bisq/commit/4dfc69e02cf2ba56634868257863b74e68cd9522) for FilterWindow
- [second one](https://github.com/bisq-network/bisq/commit/5cdb65d19e9702edafa3be0be7297ecae113ca07) for SendAlertMessageWindow
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3617

-- Commit Summary --

  * Refactor FilterWindow - remove redundant interfaces
  * Refactor SendAlertMessageWindow - remove redundant interfaces

-- File Changes --

    M desktop/src/main/java/bisq/desktop/app/BisqApp.java (10)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (29)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SendAlertMessageWindow.java (41)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3617.patch
https://github.com/bisq-network/bisq/pull/3617.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3617
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/f2620df1/attachment.html>


More information about the bisq-github mailing list