[bisq-network/bisq] (5/8) Test P2PDataStore expiration code and make testing time sensitive code easier. (#3568)

Julian Knutsen notifications at github.com
Fri Nov 15 17:14:18 UTC 2019


julianknutsen commented on this pull request.



> @@ -121,6 +124,8 @@
     private final Set<ProtectedDataStoreListener> protectedDataStoreListeners = new CopyOnWriteArraySet<>();
     private final Clock clock;
 
+    protected int maxSequenceNumberMapSizeBeforePurge;

https://github.com/julianknutsen/bisq/commit/850cd9180213f396180b447d6164e7e8c3900ac2

Guice is really new to me, but from what I found I think this solution will be better. The App will just inject the static value and the tests can pass it in through the normal constructor.

The constant didn't feel right to put in NetworkOptionKeys so let me your preference for it.

Let me know your comments and I'll create the PR to fix this up.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3568#discussion_r346926130
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/0e2b3bd3/attachment.html>


More information about the bisq-github mailing list