[bisq-network/bisq] PaymentAccount object removal from ObservableSet issue (#3572)

Julian Knutsen notifications at github.com
Fri Nov 15 17:48:14 UTC 2019


I think the issue was more with understanding why it failed initially and not directly tied to the fix. The initial PR suggested that the state changed, but until there was a good understanding of which specific state changed, was it changed intentionally, and what is the scope of a PaymentAccount mutating, it is hard to come to a consensus on the right set of fields to guarantee uniqueness.

@beingindot I really appreciate the work to identify and work on this bug. You've started a good conversation on how to approach this type of issue in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3572#issuecomment-554460213
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/9f8eb7f1/attachment.html>


More information about the bisq-github mailing list