[bisq-network/bisq] PaymentAccount object removal from ObservableSet issue (#3572)

[chimp1984]

chimp1984 requested changes on this pull request.

NACK
I don't see the need for excluding the other fields. It add some unneeded risk and testing effort. The objects should be immutable so any fields has to be fix. If we go further on that area I would recommend to think how we can refactor to make all those accounts immutable. But I think there are many other higher prio stuff to do....



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3572#pullrequestreview-317878321
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191115/1e29460a/attachment-0001.html>