[bisq-network/events] Upcoming Dev-Call "Pull Requests" (#35)

[Florian Reimair]

- howto
  - setup git (your id, pgp)
  - fork bisq
  - feature branch
  - commit little, commit often
  - check yo' stylin (try to match the surroundings)
  - commit only changes related to the PR in question (no import reorgs)
  - create PR
  - await response from reviewers
  - react, if change requests are not reacted to within 30 days, PR will be closed (no compensation)
  - ask for compensation

- why does it take so long until PRs get merged
  - formatting issues
  - unnecessary code reorgs
  - conflicts
  - ...
  - hence, PRs queue up
  - maintainers are overburdened
  - nothing moves

- optimize workflow
  - use travis to check for formatting?
  - use travis to check for bugs? (FindBugs, etc.)
  - introduced the 30 days deadline
  - we will be more rigorous with closing PRs if we feel that too much basic stuff is off

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/events/issues/35
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191118/f1edb5c3/attachment.html>