[bisq-network/bisq] Hide avoid standby mode feature on *nux OS (#3563)
Florian Reimair
notifications at github.com
Mon Nov 18 12:35:12 UTC 2019
freimair requested changes on this pull request.
other than that, I share the opinion of @wiz: Linux users have to disable sleep-mode on their own. Showing the switch on Linux promises something that does not work.
> @@ -806,8 +811,10 @@ private void activateDisplayPreferences() {
// We use opposite property (useStandbyMode) in preferences to have the default value (false) set as we want it,
// so users who update gets set avoidStandbyMode=true (useStandbyMode=false)
- avoidStandbyMode.setSelected(!preferences.isUseStandbyMode());
- avoidStandbyMode.setOnAction(e -> preferences.setUseStandbyMode(!avoidStandbyMode.isSelected()));
+ if (displayStandbyModeFeature) {
+ avoidStandbyMode.setSelected(!preferences.isUseStandbyMode());
+ avoidStandbyMode.setOnAction(e -> preferences.setUseStandbyMode(!avoidStandbyMode.isSelected()));
+ }
```suggestion
} else {
preferences.setUseStandbyMode(false)
}
```
I agree with @ripcurlx, thus, the change suggestion. I believe that is a good place to put it. Instead of attaching a switch, we set it to false.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3563#pullrequestreview-318294140
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191118/db39e7f3/attachment.html>
More information about the bisq-github
mailing list