[bisq-network/bisq] (9/9) [PR COMMENTS] Split up P2PDataStoreTest (#3587)

Christoph Atteneder notifications at github.com
Mon Nov 18 13:54:00 UTC 2019


I don't merge this PR as the commits will be part of https://github.com/bisq-network/bisq/pull/3609 anyways. So I'll close it as soon as #3609 gets merged. In the future I might do it differently as I do it right now. If we have bigger changes that rely on each other and are pushed as separate PRs, it might be better to only merge the final PR (squash and merge) and use the other PRs for initial feedback. So we don't end up with in-progress commits in our git history. Still the title of the final PR will need some change as it should sum up the whole change. Within the descriptions we should reference all other closed PRs for documentation purpose.
@freimair @julianknutsen @sqrrm What do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3587#issuecomment-555024367
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191118/18ec5c21/attachment.html>


More information about the bisq-github mailing list