[bisq-network/bisq] Reputation BSQ added to BSQ Wallet screen (#3366)

Christoph Atteneder notifications at github.com
Tue Nov 19 09:27:39 UTC 2019


ripcurlx requested changes on this pull request.

NACK - please see my comments

> @@ -125,6 +129,9 @@ public void onUpdateBalances(Coin availableBalance,
         availableNonBsqBalanceTextField.setVisible(isNonBsqBalanceAvailable);
         availableNonBsqBalanceTextField.setManaged(isNonBsqBalanceAvailable);
         availableNonBsqBalanceTextField.setText(bsqFormatter.formatBTCWithCode(availableNonBsqBalance.value));
+        

Unfortunately now there is a formatting error here

> @@ -125,6 +129,9 @@ public void onUpdateBalances(Coin availableBalance,
         availableNonBsqBalanceTextField.setVisible(isNonBsqBalanceAvailable);
         availableNonBsqBalanceTextField.setManaged(isNonBsqBalanceAvailable);
         availableNonBsqBalanceTextField.setText(bsqFormatter.formatBTCWithCode(availableNonBsqBalance.value));
+        

Unnecessary spaces

> @@ -125,6 +129,9 @@ public void onUpdateBalances(Coin availableBalance,
         availableNonBsqBalanceTextField.setVisible(isNonBsqBalanceAvailable);
         availableNonBsqBalanceTextField.setManaged(isNonBsqBalanceAvailable);
         availableNonBsqBalanceTextField.setText(bsqFormatter.formatBTCWithCode(availableNonBsqBalance.value));
+        
+        String bsqSatoshi = bsqFormatter.formatBSQSatoshisWithCode(daoFacade.getAvailableMerit());
+        reputationBalanceTextField.setText(bsqSatoshi); 

.. and here (trailing space)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3366#pullrequestreview-318887370
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191119/b96cb669/attachment.html>


More information about the bisq-github mailing list