[bisq-network/bisq] Create modal pop-up with single button taking user to Support screen if there are active support tickets (#3477)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - please see my comments

> @@ -413,6 +414,7 @@ protected Tooltip computeValue() {
 
         // Delay a bit to give time for rendering the splash screen
         UserThread.execute(() -> onUiReadyHandler.run());
+        UserThread.execute(() -> checkOpenSupportTickets());

This should be done more like the new trade protocol window like https://github.com/bisq-network/bisq/blob/95257b10f9741e7d3548c3630dca0b2b2168b366/desktop/src/main/java/bisq/desktop/main/MainViewModel.java#L271 in the MainViewModel. So it is shown after the Splash screen based on priority.

> @@ -429,6 +431,18 @@ public void onCheckpointFail() {
                 .useShutDownButton()
                 .show();
     }
+    
+    private void checkOpenSupportTickets() {
+		// Create modal pop-up with single button taking user to Support screen if there
+		// are active support tickets
+		if (model.getNumOpenSupportTickets() != null && Integer.parseInt(model.getNumOpenSupportTickets().get()) > 0) {
+			new Popup<>().attention(Res.get("portfolio.pending.support.popup.attention"))
+					.closeButtonTextWithGoTo("navigation.support")
+					.onClose(
+							() -> navigation.navigateTo(MainView.class, SupportView.class, ArbitrationClientView.class))
+					.show();

I think we should add a don't show again option for power users that might get annoyed having it popup every time it opens as long they have a support case open.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3477#pullrequestreview-318904257
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191119/18931129/attachment.html>