[bisq-network/bisq] Remove redundant interfaces from FilterWindow and SendAlertMessageWindow (#3617)

[Łukasz Usarz]

@ripcurlx I see a few places where business logic is triggered directly in a window, for example:
- [SignPaymentAccountsWindow](https://github.com/bisq-network/bisq/blob/df6812a4c958553cfaf4587bf814de9d11be1a87/desktop/src/main/java/bisq/desktop/main/overlays/windows/SignPaymentAccountsWindow.java#L283)
- [DisputeSummaryWindow](https://github.com/bisq-network/bisq/blob/df6812a4c958553cfaf4587bf814de9d11be1a87/desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java#L645)

And a few candidates for similar refactoring: 
- [UnlockDisputeAgentRegistrationWindow](https://github.com/bisq-network/bisq/blob/f3456f1920bb115a06ece23abdc3136449894895/desktop/src/main/java/bisq/desktop/main/account/register/AgentRegistrationView.java#L124)
- [SendPrivateNotificationWindow here](https://github.com/bisq-network/bisq/blob/e0de9982e2e83713f65e36085e8fc09a24fe9078/desktop/src/main/java/bisq/desktop/main/overlays/editor/PeerInfoWithTagEditor.java#L250) and [here](https://github.com/bisq-network/bisq/blob/e0de9982e2e83713f65e36085e8fc09a24fe9078/desktop/src/main/java/bisq/desktop/main/overlays/editor/PeerInfoWithTagEditor.java#L250)

I think creating unnatural interfaces just to be able to pass single (always same) function from parent is overkill - it only increase complexity with no benefit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3617#issuecomment-555458352
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191119/c85f6b8e/attachment.html>