[bisq-network/bisq] Move Payment account creation and removal from UI to core (#3586)
Bernard Labno
notifications at github.com
Tue Nov 19 13:54:52 UTC 2019
blabno commented on this pull request.
> +
+ }
+ accountAgeWitnessService.publishMyAccountAgeWitness(paymentAccount.getPaymentAccountPayload());
+ }
+ return paymentAccount;
+ }
+
+ public void removePaymentAccount(String id) {
+ PaymentAccount paymentAccount = user.getPaymentAccount(id);
+ if (paymentAccount == null) {
+ throw new NotFoundException(format("Payment account %s not found", id));
+ }
+ boolean isPaymentAccountUsed = openOfferManager.getObservableList().stream()
+ .anyMatch(openOffer -> id.equals(openOffer.getOffer().getMakerPaymentAccountId()));
+ if (isPaymentAccountUsed) {
+ throw new PaymentAccountInUseException(format("Payment account %s is used for open offer", id));
So instead of of throwing Exception we should return some Object that either contains happy path result, or some additional data in case of failure?
Exceptions are much cleaner.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3586#discussion_r347934813
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191119/364608c2/attachment.html>
More information about the bisq-github
mailing list