[bisq-network/bisq] Upgrade Gradle Shadow plugin from 4.0.2 => 5.2.0 (#3635)
Chris Beams
notifications at github.com
Tue Nov 19 17:16:51 UTC 2019
After the upgrade from Gradle 4.10.2 to 5.6.4 in commit 5fe71fa0a,
all of Bisq's shadowJar tasks started failing Gradle's incremental build
checks. This meant that repeated invocations of `gradle build` went from
a handful of seconds to more than a minute, because shadowJar tasks had
to be re-executed on every build.
For example, with --info enabled, one would see entries like this in the
build output:
> Task :seednode:shadowJar
Custom actions are attached to task ':seednode:shadowJar'.
Caching disabled for task ':seednode:shadowJar' because:
Caching has not been enabled for the task
Task ':seednode:shadowJar' is not up-to-date because:
Output property 'archiveFile' file [...]libs/seednode.jar has changed.
This problem was solved by in johnrengelman/shadow#524 and made
available in the project's recent 5.0.2 release. This patch simply bumps
the shadow plugin version to that value, and gets us back to snappy
incremental builds, e.g.:
$ gradle build
BUILD SUCCESSFUL in 7s
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3635
-- Commit Summary --
* Upgrade Gradle Shadow plugin from 4.0.2 => 5.2.0
-- File Changes --
M build.gradle (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3635.patch
https://github.com/bisq-network/bisq/pull/3635.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3635
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191119/81fbbe76/attachment-0001.html>
More information about the bisq-github
mailing list