[bisq-network/bisq] (3/5) [BUGFIX] #3629 (Duplicate payloads w/ 20-byte and 32-byte keys) (#3636)

Florian Reimair notifications at github.com
Wed Nov 20 10:25:04 UTC 2019


freimair requested changes on this pull request.

I might be missing something here so here are some control questions to foster my understanding:

> ## Upgrade behavior
> **New Seednode <--> Old Client**
> The seednode will only have 1 32-byte key for each unique payload, but the client node may still have a 20-byte key that it will send as a known key. The seednode will ignore this known key, send back the 32-byte key `Payload` and the client node will update its map with the 32-byte key. This mimics existing behavior.

- So in the real world the old client will send roughly 2MB of 20-byte known keys to the new seed node.
- The new seed node ignores all of them and respond with _all_ data (close to our single-message size limit of 10MB)? (since it only received 20-byte keys and no 32-byte key)
- Does the old client memorize the 32-byte keys? after restart?
 
> **Old Seednode <--> New Client**
> The seednode will have 1 20-byte key and 1 32-byte key for the same unique payload. The client will only have the 32-byte key and will send it is a known key. The seednode will transmit the 20-byte `Payload` back to the client who will ignore it.

- why does the old seednode have 32-byte keys?
- the client sends only 32-byte keys for its known payloads, so the seed node will send _all_ 20-byte addressed payloads to the client (roughly 10MB of data) to every client.
- every time a client connects. Because new clients will not memorize the 20-byte keys?




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3636#pullrequestreview-319734281
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191120/31f80325/attachment-0001.html>


More information about the bisq-github mailing list