[bisq-network/bisq] (4/5) Implement proper remove-before-add behavior in P2PDataStorage (#3638)

Christoph Atteneder notifications at github.com
Thu Nov 21 10:32:41 UTC 2019


> I've left the existing behavior w.r.t. broadcasting. Even if this `remove()` is the first message we have seen for a payload, we don't rebroadcast it to our peers. I'm not exactly sure what we want here, but rebroadcasting, in this case, could help network propagation and we may want to adopt the invariant that **_ANY_** state updates caused by a message are worth of rebroadcasting because the same state updates may be relevant to our peers.

@chimp1984 What do you think about that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3638#issuecomment-557022823
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191121/2d8cb731/attachment-0001.html>


More information about the bisq-github mailing list