[bisq-network/bisq] (3/5) [BUGFIX] #3629 (Duplicate payloads w/ 20-byte and 32-byte keys) (#3636)

Julian Knutsen notifications at github.com
Thu Nov 21 20:15:37 UTC 2019


I updated the bug as well but wanted to include it here.

After more investigation, 455f7d2 also fixes an additional issue where we were retransmitting every non-persistable `ProtectedStorageEntry` in the `GetUpdatedDataRequest` path.  By using the in-memory map instead of the protectedDataStore, we now stop transmitting duplicates. Here was the breakdown of the duplicate transmissions before that patch:

```
#################################################################
Received 724 instances
RefundAgent: 1 (915 B)
Filter: 2 (5.7 KB)
TempProposalPayload: 56 (33.9 KB)
MailboxStoragePayload: 457 (2.0 MB)
Alert: 1 (826 B)
Mediator: 2 (1.8 KB)
OfferPayload: 205 (249.6 KB)
################################################################# 
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3636#issuecomment-557254018
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191121/ef23264b/attachment.html>


More information about the bisq-github mailing list