[bisq-network/bisq] (4/5) Implement proper remove-before-add behavior in P2PDataStorage (#3638)

[Florian Reimair]

freimair approved this pull request.

utAck

ad rebroadcasting even if not applicable: I had that feeling for a long time now. We have stale messages in the network. Thought about resending remove messages e.g. 3 times to spread the news even if a couple of clients missed the first one. Pretty much the same for every remove message. Since the seq number is touched, there is no risk of overloading the network.

my opinion: rebroadcast even if we did not yet receive the respective add. revert if something bad happens.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3638#pullrequestreview-321164375
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191121/fa4a5ccc/attachment.html>