[bisq-network/bisq] Add missing @Named annotations for CoinFormatter injection (#3658)

Ɓukasz Usarz notifications at github.com
Fri Nov 22 09:15:12 UTC 2019


lusarz commented on this pull request.



> @@ -139,7 +142,7 @@
     public DisputeView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
                        KeyRing keyRing,
                        TradeManager tradeManager,
-                       CoinFormatter formatter,
+                       @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

Are you sure that app crash when you ommit `@Named` annotation on this particular file (`DisputeView`) ? It's an abstract class and it does not "participate" in dependency injection.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3658#discussion_r349496358
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/e4013333/attachment.html>


More information about the bisq-github mailing list