[bisq-network/bisq] Add missing @Named annotations for CoinFormatter injection (#3658)

Steven Barclay notifications at github.com
Fri Nov 22 09:33:47 UTC 2019


stejbac commented on this pull request.



> @@ -139,7 +142,7 @@
     public DisputeView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
                        KeyRing keyRing,
                        TradeManager tradeManager,
-                       CoinFormatter formatter,
+                       @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

On second thought, I might have been wrong about `@Inject` not being mandatory for Guice, since looking closer the modified `Dispute*` classes all have subclasses with `@Inject`-annotated constructors - probably only `TransactionsView` and `TakeOfferView` actually needed fixing. (I'm pretty sure it isn't mandatory by default for Spring, but perhaps Guice is stricter.)

Also, there are (probably leftover) `@FxmlView` annotations on the 3 `Dispute*` classes which mislead me to think that they were concrete components - perhaps those annotations can be removed?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3658#discussion_r349504429
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/fe76be80/attachment.html>


More information about the bisq-github mailing list