[bisq-network/bisq] Add missing @Named annotations for CoinFormatter injection (#3658)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - please see my comments

> @@ -139,7 +142,7 @@
     public DisputeView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
                        KeyRing keyRing,
                        TradeManager tradeManager,
-                       CoinFormatter formatter,
+                       @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

I think here it is not necessary as mentioned by @lusarz. At least it didn't crash for me here.

> @@ -48,7 +49,7 @@
     public DisputeAgentView(DisputeManager<? extends DisputeList<? extends DisputeList>> disputeManager,
                             KeyRing keyRing,
                             TradeManager tradeManager,
-                            CoinFormatter formatter,
+                            @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

I think here it is not necessary.

>  @FxmlView
 public abstract class DisputeClientView extends DisputeView {
     public DisputeClientView(DisputeManager<? extends DisputeList<? extends DisputeList>> DisputeManager,
                              KeyRing keyRing,
                              TradeManager tradeManager,
-                             CoinFormatter formatter,
+                             @Named(FormattingUtils.BTC_FORMATTER_KEY) CoinFormatter formatter,

I think here it is not necessary.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3658#pullrequestreview-321428232
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191122/bc82ce51/attachment.html>